Expose st_dev and st_ino fields of stat structure
#1589
Conversation
src/libponyrt/lang/stat.c
Outdated
| @@ -69,6 +71,8 @@ static void windows_stat(const char* path, pony_stat_t* p, struct __stat64* st, | |||
| p->broken = false; | |||
|
|
|||
| p->hard_links = (uint32_t)st->st_nlink; | |||
| p->device = (uint32_t)st->st_dev; | |||
There was a problem hiding this comment.
According to @dipinhora's PR, it looks like the st_dev type (dev_t) should be int64_t on Linux, and int32_t on OSX.
Perhaps that means we should be using int64_t here (to be large enough for either system)?
There was a problem hiding this comment.
negative device number? thats insane! It should not be signed for sure, maybe uint64_t ?
There was a problem hiding this comment.
I can't actually image system with 4294967296 devices :). However no one could imagine so many internet peers when IPv4 was designed
So uint64_t is reasonable enough, should I make a change ?
There was a problem hiding this comment.
I haven't investigated myself, so maybe we can get @dipinhora's input.
There was a problem hiding this comment.
I figured out the different types using clang -E test.c | grep <TYPE> or gcc -E test.c | grep <TYPE> and following the chain of types to get to the underlying machine type. test.c included every posix header file and declared a variable of each type. I did this on both OSX and Linux (ubuntu in a VM) both on my laptop.
There was a problem hiding this comment.
We discussed this on the sync call, and agreed that we should use uint64_t/U64.
|
We want to merge this before doing the 0.11.0 release (#1543). |
Praetonus
added
the
changelog - added
Makes possible to access
deviceandinodevalue from pony's FileInfo type