-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC 68: Mandatory FFI declarations #3739
Conversation
Hi @ergl, The changelog - changed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do. Release notes are added by creating a uniquely named file in the The basic format of the release notes (using markdown) should be:
Thanks. |
Release notes for this should be pretty detailed with examples of code that was previously valid and how to fix it to make it valid after the change. If there are any tricky bits, those should be highlighted. |
c1e5045
to
f19b3f6
Compare
Okay, I think all the changes in the compiler are done. I know the diff is quite large, since there are a lot of declarations going on. Probably the most important things I'd like some review on would be the last two commits, where I enforce that FFI declarations exists, and where I remove the syntax for specifying the return type on FFI calls. |
The CI errors are due to the |
@ergl You can generate the new grammar file using your newly compilerd ponyc from your PR and do: |
Ah, great! |
This is ready for review |
I'm holding off on the next release (that contains a "triggers release" fix) as this other large change might be ready soon. My target for the release is no later than this Friday. |
@jemc can you give this a review? |
@ergl are there corresponding tutorial and other changes associated with this that I would need to merge after this is released? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. This was a big initiative. Great work!
@SeanTAllen Yes, the tutorial changes are in pony-tutorial#468 @jemc Thanks! Thank you for also helping me with all LLVM comments and guiding me through the compiler |
Changes related to the implementation of RFC 68.
Opening the PR now although it's not ready, to ask for feedback, etc
Tasks:
This closes #3735