Fix OOM on MacOS when using xcode 12.5 #3793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of VM_FLAGS_SUPERPAGE_SIZE_ANY when doing allocations causes ponyc to OOM if it is built with xcode 12.5. Fixes #3789
SeanTAllen
added
the
changelog - fixed
|
@ergl this PR doesn't include updating to using xcode 12.5 in CI so we can verify this change is "safe" with an earlier xcode version. Once this is merged, I have two other macOS related PRs coming including updating our CI to use xcode 12.5. |
Closed
ergl
approved these changes
Jul 10, 2021
|
@ergl this is a pretty straightforward change. for a review, i'm most interested in, "are the release notes clear?" |
|
@SeanTAllen Yes, I think they're fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of VM_FLAGS_SUPERPAGE_SIZE_ANY when doing allocations causes
ponyc to OOM if it is built with xcode 12.5.
Fixes #3789