Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] implement http.Pusher on our composite gzip/response writer #45

Merged
merged 2 commits into from
Jan 25, 2017

Conversation

nilslice
Copy link
Contributor

Fix for #43

gzipResponseWriter needed to implement http.Pusher and additionally set the Accept-Encoding header on the http.PushOptions struct argument.

Also removed defer from the call to push in handlers, since its likely that Pushable references are dependencies of their parent content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant