Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approve AToken once #21

Merged
merged 4 commits into from
Jul 6, 2021
Merged

Approve AToken once #21

merged 4 commits into from
Jul 6, 2021

Conversation

aodhgan
Copy link
Contributor

@aodhgan aodhgan commented Jun 29, 2021 •
edited
Loading

PierrickGT
PierrickGT suggested changes Jun 30, 2021
View reviewed changes
test/ATokenYieldSource.test.ts Outdated Show resolved Hide resolved
@PierrickGT PierrickGT changed the base branch from main to fixes/c4-audit June 30, 2021 13:16
@PierrickGT PierrickGT force-pushed the audit-fix-93 branch 5 times, most recently from de28814 to 5c5adde Compare July 5, 2021 13:36
@coveralls
Copy link

coveralls commented Jul 5, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 98.667% when pulling fbcf2e8 on audit-fix-93 into a4f1406 on fixes/c4-audit.

@PierrickGT PierrickGT self-assigned this Jul 5, 2021
asselstine
asselstine requested changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@asselstine asselstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need a function to re-approve the max amount, in case for whatever reason the approval level drops too low.

@PierrickGT
Copy link
Contributor

We also need a function to re-approve the max amount, in case for whatever reason the approval level drops too low.

@asselstine added in this commit: efe08df

@PierrickGT PierrickGT requested a review from asselstine July 6, 2021 14:43
asselstine
asselstine approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@asselstine asselstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...with a test! Good job.

@PierrickGT PierrickGT merged commit 8a74057 into fixes/c4-audit Jul 6, 2021
@PierrickGT PierrickGT deleted the audit-fix-93 branch July 6, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asselstine asselstine asselstine approved these changes

@PierrickGT PierrickGT PierrickGT approved these changes

Assignees

@PierrickGT PierrickGT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aodhgan @coveralls @PierrickGT @asselstine