update to support SafeERC20 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierrickGT
suggested changes
Jul 2, 2021
contracts/BadgerYieldSource.sol
Outdated
| @@ -3,6 +3,8 @@ | |||
| pragma solidity 0.6.12; | |||
|
|
|||
| import { IYieldSource } from "@pooltogether/yield-source-interface/contracts/IYieldSource.sol"; | |||
| import "@openzeppelin/contracts/token/ERC20/IERC20.sol"; | |||
| import "@openzeppelin/contracts/token/ERC20/SafeERC20.sol"; | |||
| import "@openzeppelin/contracts/math/SafeMath.sol"; | |||
| import "./IBadgerSett.sol"; | |||
| import "./IBadger.sol"; | |||
There was a problem hiding this comment.
Remove this line and the file in the repo.
contracts/BadgerYieldSource.sol
Outdated
Comment on lines
22
to
24
| constructor(IBadgerSett badgerSettAddr, IERC20 badgerAddr) public { | ||
| badgerSett = badgerSettAddr; | ||
| badger = badgerAddr; |
There was a problem hiding this comment.
Would be more readable if it was written this way:
Suggested change
| constructor(IBadgerSett badgerSettAddr, IERC20 badgerAddr) public { | |
| badgerSett = badgerSettAddr; | |
| badger = badgerAddr; | |
| constructor(IBadgerSett _badgerSettAddr, IERC20 _badgerAddr) public { | |
| badgerSett = _badgerSettAddr; | |
| badger = _badgerAddr; |
There was a problem hiding this comment.
I like that. It's also consistent with our convention of using _ for function args
Pull Request Test Coverage Report for Build 994694853
💛 - Coveralls |
asselstine
approved these changes
Jul 5, 2021
PierrickGT
approved these changes
Jul 12, 2021
asselstine
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code-423n4/2021-06-pooltogether-findings#112