Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add onERC721Received support #300

Merged
merged 2 commits into from
Jul 12, 2021
Merged

add onERC721Received support #300

merged 2 commits into from
Jul 12, 2021

Conversation

kamescg
Copy link
Contributor

@kamescg kamescg commented Jun 28, 2021

@kamescg kamescg mentioned this pull request Jun 28, 2021
Open
@PierrickGT PierrickGT self-assigned this Jul 2, 2021
PierrickGT
PierrickGT approved these changes Jul 2, 2021
View reviewed changes
contracts/prize-pool/PrizePool.sol Outdated Show resolved Hide resolved
asselstine
asselstine requested changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@asselstine asselstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to see a test for this

@kamescg
Copy link
Contributor Author

kamescg commented Jul 12, 2021

@asselstine The onERC721Received test has been added to the PrizePool.test.js file - checking balanceOf of update and event emission.

@kamescg kamescg merged commit 49f6d89 into master Jul 12, 2021
@kamescg kamescg deleted the fix/118 branch July 15, 2021 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asselstine asselstine asselstine approved these changes

@PierrickGT PierrickGT PierrickGT approved these changes

Assignees

@PierrickGT PierrickGT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamescg @PierrickGT @asselstine