fix/90 prevent locking user funds in _withdrawFromVault #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierrickGT
suggested changes
Jul 5, 2021
| @@ -191,7 +191,7 @@ contract YearnV2YieldSource is IYieldSource, ERC20Upgradeable, OwnableUpgradeabl | |||
| } | |||
| uint256 currentBalance = token.balanceOf(address(this)); | |||
|
|
|||
| return previousBalance.sub(currentBalance); | |||
| return currentBalance > previousBalance ? currentBalance.sub(previousBalance) : 0; | |||
There was a problem hiding this comment.
Do we really need this ternary operator?
Cause if currentBalance is equal to previousBalance, it will inevitably return 0.
Also vault.withdraw(yShares); on line 190 should be vault.withdraw(yShares, address(this));, vault shares need to be minted to the yield source contract and not the sender.
https://yearn.github.io/yearn-devdocs/v2/smart-contracts/vault#withdraw-2
There was a problem hiding this comment.
Agreed....I don't think the check is needed. It might be needed if there were rounding errors, but it doesn't appear possible as it's just a token balance.
asselstine
approved these changes
Jul 13, 2021
PierrickGT
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/pooltogether/pooltogether-yearnv2-yield-source/pull/new/fix/90