add nonreentrant to supplyTokenTo and redeemToken function #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierrickGT
approved these changes
Jul 2, 2021
aodhgan
force-pushed
the
fix/119
branch
2 times, most recently
from
850fba6 to
a4cb491
Compare
asselstine
requested changes
Jul 5, 2021
|
|
||
| import "./ISushiBar.sol"; | ||
| import "./ISushi.sol"; | ||
|
|
||
| /// @title A pooltogether yield source for sushi token | ||
| /// @author Steffel Fenix | ||
| contract SushiYieldSource is IYieldSource { | ||
| contract SushiYieldSource is IYieldSource, ReentrancyGuard { |
There was a problem hiding this comment.
@asselstine there is no need to initialize it when using the non upgradeable version one no?
asselstine
approved these changes
Jul 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: code-423n4/2021-06-pooltogether-findings#119