fix: use appropriate libcosmic patch URL for cargo #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Cargo recording valid URLs in the lockfile and correctly finding the dependency when using `cargo vendor` (otherwise `cargo build --offline` will not work with vendored sources). It uses a URL that follows the Cargo.toml specification, but still works around <rust-lang/cargo#10756>.
mmstick
approved these changes
Aug 31, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ed9ea6c#r145966372 (cc @mmstick)
This fixes Cargo recording invalid URLs in the lockfile and not correctly finding the dependency when using
cargo vendor(sincecargo build --offlinewould not work with vendored sources with invalid URLs)It uses a URL that follows the Cargo.toml specification, but still works around rust-lang/cargo#10756
Other COSMIC projects are already using this workaround:
https://github.com/pop-os/cosmic-settings/blob/a46587fb6e945b9e213a337bbe3df14acacccae5/Cargo.toml#L53-L54
https://github.com/pop-os/xdg-shell-wrapper/blob/b5480042615ecfcf30262d5a40625e8f430b474a/Cargo.toml#L44-L48
https://github.com/pop-os/cosmic-comp/blob/536484e9dae289cc5590d35e18096ba24e7d0f1f/Cargo.toml#L118-L119