Fix button events being sent when super is held #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCapucho
changed the title
Drakulix
requested changes
Aug 19, 2024
Drakulix
reviewed
Aug 20, 2024
JCapucho
force-pushed
the
fix-right-click-resize-passtrough
branch
from
8e93c0f
to
b4d942a
Compare
|
I've switched the code to unset the grab instead of tracking the suppression status on the grab this greatly simplifies the code. I've also change the code so that the suppression is only done in the buttons handled by the compositor by pulling the match out. I'm sure the code isn't good enough yet but just wanted to know if the overall structure is sound. And thank you for guiding me while implementing this :) |
Drakulix
reviewed
Aug 22, 2024
JCapucho
force-pushed
the
fix-right-click-resize-passtrough
branch
from
b4d942a
to
9b76a79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #686
Previously when doing Super+{Left,Right} Click the compositor would still send the button event to the client, for left click this didn't cause issues most of the time but for right click this caused many issues because it would usually open a context menu which would cause the resize to stop immediately.
This PR fixes the issue by not sending any button events if the logo key is held.