Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for incorrect git url for 'smithay' #818

Closed
wants to merge 1 commit into from

Conversation

Cypher1
Copy link

@Cypher1 Cypher1 commented Sep 5, 2024

No description provided.

@Drakulix
Copy link
Member

Drakulix commented Sep 5, 2024

This is by design (and works) due to rust-lang/cargo#7497 . Otherwise the patch breaks.

@Drakulix Drakulix closed this Sep 5, 2024
@Cypher1
Copy link
Author

Cypher1 commented Sep 5, 2024

Sorry, the URL has an extra / in it causing anyone using

[url "git@github.com:"]
	insteadOf = "https://github.com/"

To fail to authenticate.

I'd love to understand why it's part of the design of cosmic-comp
Edit: Ah, curious that 'patch' needs this... that seems... wrong somehow.
Thanks though

@Drakulix
Copy link
Member

Drakulix commented Sep 5, 2024

It is, a proper fix for cargo is need before we can fix it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants