Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add menu and context item icons and update libcosmic. #660

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edfloreshz
Copy link
Contributor

This pull request updates libcosmic to its latest version, this includes new features and improvements to the application, including the addition of an "About" section, various updates to the context drawer functionality and menu item icons.

Summary:

  • Added an "About" section to the application, including details such as the name, author, version, license, and links to the repository and support.
  • Introduced an icon cache to manage and optimize the use of icons throughout the application.

Context Drawer Enhancements:

  • Updated the context drawer to use a new context_drawer module, simplifying the way context pages are displayed and managed.

Codebase Updates:

  • Included new icons for various actions in the application menu.
  • Updated the Cargo.toml file to include the "about" feature.

Localization:

  • Added new localization entries for the "About" section.

screenshot-2024-11-18-23-54-55

screenshot-2024-11-18-23-55-00

screenshot-2024-11-18-23-55-04

screenshot-2024-11-18-23-55-10

screenshot-2024-11-18-23-55-16

@git-f0x
Copy link
Contributor

git-f0x commented Nov 19, 2024

This likely needs UX approval.
But unrelated to that, the header menu width should possibly be increased slightly (since it isn't dynamic yet), since e.g. Show hidden files is very close to its shortcut.
Edit: Also, the about widget shouldn't be added yet, since the target Rust version is 1.80 (see #658).

@edfloreshz
Copy link
Contributor Author

I can remove the about feature, no problem.

@jackpot51 jackpot51 marked this pull request as draft November 22, 2024 15:47
@jackpot51
Copy link
Member

I am converting to a draft until we decide on this. The icons will need to be source from the cosmic icon theme, at least.

@edfloreshz
Copy link
Contributor Author

Sure, I'll wait until we hear from Maria to switch the icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants