Wrap::Word inserts newline for trailing space (after word)

[grovesNL]

If we have text like Testing Spacing in the rich-text example, you can see that the space causes a full empty line to be inserted (tested with the rich-text example):

(the cursor also does an interesting thing in this situation)

The behavior seems to have changed in #78. Before #78 this would look like:

The previous behavior seems better for display, because I wouldn't expect a space to wrap a whole line. Instead I'd expect the space to kind of bind to the word before it, so that "Testing " remains on the first line.

If the old behavior is preferred, I'll try to submit a PR to change how we wrap in this case.

The current handling for word wrapping is located in

cosmic-text/src/shape.rs

Lines 831 to 873 in aa1b37a

	// Wrap::Word
	let mut trailing_space_width = None;
	if let Some(previous_word) = span.words.get(i + 1) {
	// Current word causing a wrap is not whitespace, so we ignore the
	// previous word if it's a whitespace
	if previous_word.blank {
	trailing_space_width =
	Some(previous_word.x_advance * font_size);
	number_of_blanks = number_of_blanks.saturating_sub(1);
	}
	}
	if let Some(width) = trailing_space_width {
	add_to_visual_line(
	&mut current_visual_line,
	span_index,
	(i + 2, 0),
	fitting_start,
	word_range_width - width,
	number_of_blanks,
	);
	} else {
	add_to_visual_line(
	&mut current_visual_line,
	span_index,
	(i + 1, 0),
	fitting_start,
	word_range_width,
	number_of_blanks,
	);
	}
	visual_lines.push(current_visual_line);
	current_visual_line = VisualLine::default();
	number_of_blanks = 0;
	if word.blank {
	fit_x = line_width;
	word_range_width = 0.;
	fitting_start = (i, 0);
	} else {
	fit_x = line_width - word_width;
	word_range_width = word_width;
	fitting_start = (i + 1, 0);
	}

and

cosmic-text/src/shape.rs

Lines 923 to 968 in aa1b37a

	// Wrap::Word
	let mut trailing_space_width = None;
	if i > 0 {
	if let Some(previous_word) = span.words.get(i - 1) {
	// Current word causing a wrap is not whitespace, so we ignore the
	// previous word if it's a whitespace
	if previous_word.blank {
	trailing_space_width =
	Some(previous_word.x_advance * font_size);
	number_of_blanks = number_of_blanks.saturating_sub(1);
	}
	}
	}
	if let Some(width) = trailing_space_width {
	add_to_visual_line(
	&mut current_visual_line,
	span_index,
	fitting_start,
	(i - 1, 0),
	word_range_width - width,
	number_of_blanks,
	);
	} else {
	add_to_visual_line(
	&mut current_visual_line,
	span_index,
	fitting_start,
	(i, 0),
	word_range_width,
	number_of_blanks,
	);
	}
	visual_lines.push(current_visual_line);
	current_visual_line = VisualLine::default();
	number_of_blanks = 0;
	if word.blank {
	fit_x = line_width;
	word_range_width = 0.;
	fitting_start = (i + 1, 0);
	} else {
	fit_x = line_width - word_width;
	word_range_width = word_width;
	fitting_start = (i, 0);
	}
	}

[Imberflur]

I've noticed that trailing spaces also affect centered and right aligned text. At least, when there are multiple trailing spaces.

edit: considering that it only seems to happen with multiple spaces, this might be intended, I'm not sure what the typical behavior is in this case...

(I see this was discussed a bit in #78, it seems like the ideal behavior is different for different cases)