Skip to content

Merge pull request #175 from Imberflur/stable-wrap

Sign in for the full log view
GitHub Actions / clippy succeeded Aug 28, 2023 in 0s

clippy

5 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 5
Note 0
Help 0

Versions

  • rustc 1.71.1 (eb26296b5 2023-08-03)
  • cargo 1.71.1 (7f1d04c00 2023-07-29)
  • clippy 0.1.71 (eb26296 2023-08-03)

Annotations

Check warning on line 464 in src/edit/vi.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

docs for function returning `Result` missing `# Errors` section

warning: docs for function returning `Result` missing `# Errors` section
   --> src/edit/vi.rs:460:5
    |
460 | /     pub fn load_text<P: AsRef<std::path::Path>>(
461 | |         &mut self,
462 | |         path: P,
463 | |         attrs: crate::Attrs,
464 | |     ) -> std::io::Result<()> {
    | |____________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

Check warning on line 40 in src/edit/vi.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

docs for function returning `Result` missing `# Errors` section

warning: docs for function returning `Result` missing `# Errors` section
  --> src/edit/vi.rs:35:5
   |
35 | /     pub fn load_text<P: AsRef<std::path::Path>>(
36 | |         &mut self,
37 | |         font_system: &mut FontSystem,
38 | |         path: P,
39 | |         attrs: crate::Attrs,
40 | |     ) -> std::io::Result<()> {
   | |____________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
note: the lint level is defined here
  --> src/lib.rs:86:9
   |
86 | #![warn(clippy::missing_errors_doc)]
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 93 in src/buffer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `impl` can be derived

warning: this `impl` can be derived
  --> src/buffer.rs:89:1
   |
89 | / impl Default for Affinity {
90 | |     fn default() -> Self {
91 | |         Affinity::Before
92 | |     }
93 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
   = note: `#[warn(clippy::derivable_impls)]` on by default
   = help: remove the manual implementation...
help: ...and instead derive it...
   |
58 + #[derive(Default)]
59 | pub enum Affinity {
   |
help: ...and mark the default variant
   |
59 ~     #[default]
60 ~     Before,
   |

Check warning on line 1371 in src/shape.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `else { if .. }` block can be collapsed

warning: this `else { if .. }` block can be collapsed
    --> src/shape.rs:1365:24
     |
1365 |                   } else {
     |  ________________________^
1366 | |                     if self.rtl {
1367 | |                         start_x - x
1368 | |                     } else {
1369 | |                         x
1370 | |                     }
1371 | |                 },
     | |_________________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
     = note: `#[warn(clippy::collapsible_else_if)]` on by default
help: collapse nested if block
     |
1365 ~                 } else if self.rtl {
1366 +                     start_x - x
1367 +                 } else {
1368 +                     x
1369 ~                 },
     |

Check warning on line 67 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

lint `clippy::integer_arithmetic` has been renamed to `clippy::arithmetic_side_effects`

warning: lint `clippy::integer_arithmetic` has been renamed to `clippy::arithmetic_side_effects`
  --> src/lib.rs:67:10
   |
67 | #![allow(clippy::integer_arithmetic)]
   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::arithmetic_side_effects`
   |
   = note: `#[warn(renamed_and_removed_lints)]` on by default