Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider setting up continuous integration to check pull requests against rustc 1.24.1 #4

Open
dtolnay opened this issue Dec 3, 2018 · 3 comments

Comments

@dtolnay
Copy link

dtolnay commented Dec 3, 2018

For example a minimal .travis.yml for this would be:

language: rust
rust: 1.24.1
script: cargo check

This would avoid the problem described in #2 (comment) of pull requests breaking compatibility with rustc versions that need to be supported.

otavio added a commit to OSSystems/sys-mount that referenced this issue Aug 6, 2019
Fixes: pop-os#4

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
otavio added a commit to OSSystems/sys-mount that referenced this issue Aug 6, 2019
Fixes: pop-os#4

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
@otavio
Copy link
Contributor

otavio commented Aug 6, 2019

@mmstick which is the oldest supported version?

@mmstick
Copy link
Member

mmstick commented Aug 6, 2019

Unsure what the oldest supported version of the crate is, but I added a toolchain file to limit it to Rust 1.35.0, because that's what Ubuntu Bionic currently support.

@otavio
Copy link
Contributor

otavio commented Aug 7, 2019

The 1.24.1 works just fine, I'd avoid pining a new version without a need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants