Apply and enforce formatting #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieleades
force-pushed
the
refactor/format
branch
from
670a6ef
to
de60386
Compare
|
rebased on master |
Merged
danieleades
force-pushed
the
refactor/format
branch
from
de60386
to
0ed6359
Compare
|
rebase and tidy commits |
|
github action run results can be checked here - https://github.com/danieleades/upgrade/pull/3/checks?check_run_id=2360001747 |
crawfxrd
reviewed
Apr 16, 2021
danieleades
force-pushed
the
refactor/format
branch
from
0ed6359
to
1fe6d81
Compare
crawfxrd
approved these changes
Apr 21, 2021
|
Formatting changes will destroy mergeability of development branch. Had to undo the recently-merged commits. |
|
@mmstick I take it you don't want to persue enforcing the formatting policy in CI? |
|
Maybe when it's not actively in development |
Fair enough. Though I would point out that a pull request to add formatting is, by it's very nature, very easy to rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apply formatting, and add a CI action to check formatting
closes #152