Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shifting of coordinates #1570

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

petrelharp
Copy link
Contributor

As discussed in #1404.

Closes #1404.

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.83%. Comparing base (e52b33e) to head (d6e20d8).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1570   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files         131      130    -1     
  Lines        4340     4354   +14     
  Branches      595      597    +2     
=======================================
+ Hits         4333     4347   +14     
  Misses          3        3           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@petrelharp petrelharp merged commit f3769ae into popsim-consortium:main Jul 6, 2024
8 of 9 checks passed
Copy link
Collaborator

@nspope nspope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using left/right, output coordinate system is relative to start of contig
2 participants