Add husky and lint-staged to run prettier before commit. Adds a11y pl…

…ugin for linter (#30) Also adds a11y plugin for a static accessibility check with the recommended rules turned on.
populist-vote · May 23, 2022 · f3a72a6 · f3a72a6 · vercel · May 23, 2022
1 parent d35666d
commit f3a72a6
Show file tree

Hide file tree

Showing 8 changed files with 715 additions and 4 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -2,8 +2,10 @@
   "extends": [
     "next/core-web-vitals",
     "plugin:@typescript-eslint/recommended",
-    "prettier"
+    "prettier",
+    "plugin:jsx-a11y/recommended"
   ],
+  "plugins": ["jsx-a11y"],
   "rules": {
     "no-warning-comments": [
       "warn",

diff --git a/.husky/.gitignore b/.husky/.gitignore
@@ -0,0 +1 @@
+_
diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -0,0 +1,4 @@
+#!/bin/sh
+. "$(dirname "$0")/_/husky.sh"
+
+npx lint-staged
diff --git a/.lintstagedrc.js b/.lintstagedrc.js
@@ -0,0 +1,10 @@
+const path = require('path')
+
+const buildEslintCommand = (filenames) =>
+  `next lint --fix --file ${filenames
+    .map((f) => path.relative(process.cwd(), f))
+    .join(' --file ')}`
+
+module.exports = {
+  '*.{js,jsx,ts,tsx}': [buildEslintCommand],
+}
diff --git a/components/Nav/Nav.tsx b/components/Nav/Nav.tsx
@@ -56,7 +56,7 @@ export default function Nav({
 
         {showBackButton && (
           <Link href={`/politicians`} passHref>
-            <a aria-label="Go back">
+            <a href={`/politicians`} aria-label="Go back">
               <FaChevronLeft
                 className={styles.backButton}
                 color="var(--white)"