JS Capstone Project PR #36

porag-m06 · 2023-06-10T15:30:12Z

Hi, Please find the PR for review below,

Live Demo : The kanban Project

Presentation: Video

Highlights:

Used API for Sending and receiving data.
Used Base API fetching meal data (Meals DB: data about meals.)
Used Involvement API to record the different user interactions (e.g. likes, reservations).**
Used ES6 syntax.
Used ES6 modules.
Used callbacks and promises.
Used web pack.
Applied JavaScript best practices and language style guides in code.
Added unit tests.
Followed Gitflow.

Initial setup

Header footer setup

display list of items on the home page done- Student A

Like feature

reservation counter test

…taurant into development

porag-m06 · 2023-06-10T15:38:31Z

Hi, we are facing a webhit error while making the pull request here, however, only a warning and hints but no error locally. And our app is also working fine.

Video Demo

We tried to resolve this issue for the last 24 hours but with no luck and it would be great if we can have some insight on that, please.

Please find the screenshot below.

Thank you.

Ghiftee

STATUS: CHANGES REQUIRED ♻️♻️

Hello @porag-m06, @ghermaico135 and @maryam0007 👋🏽

Good job working on the project so far!
To highlight 👍🏽
✔️ App is well designed
✔️ Tests pass
✔️ Involvement API is used

However, there are some issues that you need to work on to go to the next project but you are almost there!

Required Changes ♻️

_Check the comments under the review 👇🏽 _

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can consider closing the issues that have already been fixed.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Ghiftee · 2023-06-10T16:43:06Z

src/index.js

+    /* eslint-disable */
+    console.error(error.message);
+    /* eslint-enable */
+  }


Kindly do not disable linters as they help us write cleaner code.

Hello, @Ghiftee thank you so much for the detailed review, however, could you please suggest what could be an alternative here to get the message in case an error occurs? [in this particular case inside a catch block]

Ghiftee · 2023-06-10T16:43:31Z

src/index.js

+    /* eslint-disable */
+    console.log("No data found while fetching for meal list!!!");
+    /* eslint-enable */


Kindly do not disbale linters as they help us write cleaner code

Sure, will be removing that. Thank you

Ghiftee · 2023-06-10T16:44:53Z

src/index.js

+                <h4><span id = "s${foodArray[index].idMeal}">0</span> likes</h4>
+               </div>
+               <div class="flex crd-btns">
+                <button class="comment">Comments</button>


Your comments section is just a button and does not work. However, according to the requirements, you should have a comment popup should as you do for reservations. Kindly add this feature shown in the image below

Hello, again, So, in this case we were only 2 people (@ghermaico135 as Student C and me @porag-m06 - as Student A) on the team. Then @maryam0007 as student B Joined. And we divided and assigned our tasks according to the instructions.

Implementation of the Comment section was assigned on @maryam0007, however, unfortunately, due to her illness she could not complete any of the assigned tasks according to the instructions.

Therefore, that part is unfinished. In this scenario is mandatory for us 2 (As students A and C ) to complete the part of Student B as well to get approved? It would be great if you could shed some light on it, please.

As, technically we are only 2 people team. Thanks

https://github.com/porag-m06/Kanban-Restaurant/projects/1

As suggested by the previous reviewer, please implement the comments section so that users can post comments. It's so unfortunate that Student B fell sick but when such a thing occurs, you need to contact the Student Success team and forge a way forward together. Deciding on a course of action individually is not professional and could lead to disastrous results on a job. Please reach out to The Student Success Team at your earliest convenience. 👍🏾

Ghiftee · 2023-06-10T16:57:17Z

src/modules/reservation.js

+          /* eslint-disable */
+          console.error(error.message);
+          /* eslint-enable */


Kindly do not disable linters as they help us write cleaner code.

please suggest what could be an alternative here to get the message in case an error occurs? [in this particular case inside a catch block]

Or, should we remove it any ways? Thanks

If the user needs to see the error message, you can display it on the webpage, style it and reword it so that it's not technical and a user can understand what the problem is and what they should do. If the user does not need to see it, you should handle it in code so that the application does not crash. logging the error to the console can leak confidential information to hackers and users do not always check the console when using web apps. 😄

Ghiftee · 2023-06-10T16:57:43Z

src/modules/reservation.js

+      }, 1000);
+    }, 1000);
+  });
+};// displayMeals


Please do not leave commented code that are not descriptive in your codebase.

Sure, will be removing that. thanks

Ghiftee · 2023-06-10T17:08:00Z

src/style.css

+  padding: 30px;
+  display: block;
+
+  /* visibility: hidden; */


Please do not leave commented code that is not descriptive in your codebase, this would give a cleaner and more professional code.

Sure, will be removing that. Thank you

Ghiftee · 2023-06-10T17:08:06Z

src/style.css

+  margin-top: 1rem;
+  margin-left: 1.3rem;
+
+  /* background-color: #fff; */


Please do not leave commented code that is not descriptive in your codebase, this would give a cleaner and more professional code.

Sure, will be removing that. Thank you

Ghiftee · 2023-06-10T17:11:08Z

src/style.css

+.crd-btns {
+  gap: 17px;
+}


Kindly ensure that the name of the meal, like button, comment and reservation buttons are positioned as in the image below:

Given design

Your design

Thank you so much for the kind review, however, just to be sure as part of following the medium fidelity wireframe, can't the implementation be improvised a bit?

Thanks

Ghiftee · 2023-06-10T17:13:31Z

src/style.css

+}
+
+footer h3 {
+  text-align: center;


Kindly ensure that your footer design matches the given mockup.

Given design

Your design

can't the implementation be improvised according the to design theme?
Thanks

[ OPTIONAL] Please note that the footer text is left aligned. It would be better if you did the same. 👍🏾

Ghiftee · 2023-06-10T17:19:04Z

README.md

+- **Use of medium-fidelity wireframe attached below to create a UI.**
+   <img src="./leaderboard_wireframe.png" alt="Leaderboard wireframe" width="auto"  height="auto" />
+- **Developed UI:**
+   <img src="./leaderboard_Design.png" alt="Leaderboard wireframe" width="auto"  height="auto" />


There are some broken images in your README, please fix them to give you a more professional README.

Sure, will be removing that. Thank you

…date design

mwanawabangona

Hi @team!,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, that has got linter errors 😞

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

porag-m06 · 2023-06-10T18:54:27Z

Hi, @mwanawabangona
Hi, we are facing a webhit error while making the pull request here, however, only a warning and hints but no error locally. And our app is also working fine.

Video Demo

We tried to resolve this issue for the last 24 hours but with no luck and it would be great if we can have some insight on that, please.

Please find details in the below link that was mentioned in the previous review request,
#36 (comment)

Thanks

wayungi

Hi @porag-m06 & team,

Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't been addressed yet.

Highlights

The app is well designed 👍🏾
Tests are passing 👍🏾
Involvement API is used 👍🏾

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

wayungi · 2023-06-10T19:51:34Z

src/style.css

+}
+
+footer h3 {
+  text-align: center;


[ OPTIONAL] Please note that the footer text is left aligned. It would be better if you did the same. 👍🏾

alexander16108

Hi Team 👋🏾

Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉

Optional suggestions

please add a working link of your live demo to your readme file because when you code base I being used your readme file help visitor navigate through your project

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

porag-m06 and others added 30 commits June 5, 2023 19:16

initial linter and webpack configuration

56fd4e0

updated readme.md

44d387c

Add readme author

91f55bf

Added author

b64b318

Set up the project with Webpack and Jest- group task - Done

8a5aeb3

Merge pull request #22 from porag-m06/initial-setup

aec57ec

Initial setup

Added html for header and footer

887c8cc

Add comment

b96c93f

Add style to header

db4a9d5

index.html style updated

c1aad95

Merge pull request #23 from porag-m06/header-footer-setup

adfb235

Header footer setup

display list of items on the home page done- Student A

be268bb

Merge pull request #24 from porag-m06/disply-list-on-home

b8cf16b

display list of items on the home page done- Student A

Add reservation structure and style

f0297e0

eventlistener fixed to reservation buttons

df00dee

display meals details fixed

9ed20a8

get reservation history from involvment api added and fixed

13ef4ac

add reservation done

2ea74f4

Add reservation style

04b1177

reservation history count fixed & reservation modal close btn fixed

a058f65

style updated

35c7013

fixed linters and fixed reservation counter if zero

84ea42a

add reservation style

8d8e82c

refreshing reservation history after a new reservation done

a0e4d7f

pre issue commit

6a32bc3

like feature working prototype done

1d8581c

like functionality added on the home page items

c3e6cd5

test for homepage food menu item counter added

8139853

update

6f98e9c

added food item count to the nav menu item

ea1b352

porag-m06 and others added 8 commits June 10, 2023 18:45

fixed linter errors

46846f2

Merge pull request #34 from porag-m06/like-feature

d842508

Like feature

Add reservation counter test

ec565ce

Merge pull request #35 from porag-m06/reservation-test

593715a

reservation counter test

linter & style update

14ad899

live demo link added

5167e16

update

2a93029

Merge branch 'development' of https://github.com/porag-m06/Kanban-Res…

43dffe4

…taurant into development

Ghiftee suggested changes Jun 10, 2023

View reviewed changes

All PR requested changes implemented: e.g. removed logs, comments, up…

76afbe1

…date design

porag-m06 temporarily deployed to github-pages June 10, 2023 18:23 — with GitHub Pages Inactive

mwanawabangona suggested changes Jun 10, 2023

View reviewed changes

removed Hero banner

08033cf

porag-m06 temporarily deployed to github-pages June 10, 2023 18:49 — with GitHub Pages Inactive

Add the counter test module

a0d20a6

ghermaico135 temporarily deployed to github-pages June 10, 2023 19:06 — with GitHub Pages Inactive

wayungi suggested changes Jun 10, 2023

View reviewed changes

changes on the style

4cb6e89

ghermaico135 temporarily deployed to github-pages June 10, 2023 21:50 — with GitHub Pages Inactive

alexander16108 approved these changes Jun 10, 2023

View reviewed changes

ghermaico135 merged commit 719f8e8 into main Jun 10, 2023
7 of 8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JS Capstone Project PR #36

JS Capstone Project PR #36

porag-m06 commented Jun 10, 2023 •

edited

Loading

porag-m06 commented Jun 10, 2023 •

edited

Loading

Ghiftee left a comment

Ghiftee Jun 10, 2023

porag-m06 Jun 10, 2023

Ghiftee Jun 10, 2023

porag-m06 Jun 10, 2023 •

edited

Loading

Ghiftee Jun 10, 2023

porag-m06 Jun 10, 2023

porag-m06 Jun 10, 2023

porag-m06 Jun 10, 2023

wayungi Jun 10, 2023

Ghiftee Jun 10, 2023

porag-m06 Jun 10, 2023

wayungi Jun 10, 2023

Ghiftee Jun 10, 2023

porag-m06 Jun 10, 2023

Ghiftee Jun 10, 2023

porag-m06 Jun 10, 2023

Ghiftee Jun 10, 2023

porag-m06 Jun 10, 2023

Ghiftee Jun 10, 2023 •

edited

Loading

porag-m06 Jun 10, 2023

Ghiftee Jun 10, 2023

porag-m06 Jun 10, 2023

wayungi Jun 10, 2023

Ghiftee Jun 10, 2023

porag-m06 Jun 10, 2023

mwanawabangona left a comment

porag-m06 commented Jun 10, 2023

wayungi left a comment

wayungi Jun 10, 2023

alexander16108 left a comment

JS Capstone Project PR #36

JS Capstone Project PR #36

Conversation

porag-m06 commented Jun 10, 2023 • edited Loading

Live Demo : The kanban Project

Presentation: Video

Highlights:

porag-m06 commented Jun 10, 2023 • edited Loading

Ghiftee left a comment

Choose a reason for hiding this comment

STATUS: CHANGES REQUIRED ♻️♻️

Required Changes ♻️

Optional suggestions

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

porag-m06 Jun 10, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ghiftee Jun 10, 2023 • edited Loading

Choose a reason for hiding this comment

Given design

Your design

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Given design

Your design

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mwanawabangona left a comment

Choose a reason for hiding this comment

Invalid Code Review Request

porag-m06 commented Jun 10, 2023

wayungi left a comment

Choose a reason for hiding this comment

Highlights

Required Changes ♻️

Optional suggestions

Choose a reason for hiding this comment

alexander16108 left a comment

Choose a reason for hiding this comment

Optional suggestions

porag-m06 commented Jun 10, 2023 •

edited

Loading

porag-m06 commented Jun 10, 2023 •

edited

Loading

porag-m06 Jun 10, 2023 •

edited

Loading

Ghiftee Jun 10, 2023 •

edited

Loading