New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented safer loading of json files #10

Merged

porimol merged 1 commit into porimol:master from kaspersorensen:safe_file_loading

Oct 17, 2019

Contributor

kaspersorensen commented Oct 16, 2019

Did a few things related to loading the JSON files ...

Made a test so that you can verify the problem-free loading of all files using python setup.py test.
Used a with statement around the file loading to ensure that the file handle is released after reading.
Added the UTF-8 encoding for safety (makes code portable to Windows).


          Implemented safer loading of json files

5b33a51

kaspersorensen mentioned this pull request

Avoided failures in name related API methods #11

Merged

porimol merged commit 5b33a51 into porimol:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet