Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix div-by-zero and potential blowing up in phaseshift~ #635

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Fix div-by-zero and potential blowing up in phaseshift~ #635

merged 1 commit into from
Nov 19, 2023

Commits on Nov 19, 2023

  1. Fix div-by-zero and potential blowing up in phaseshift~ 

    Both Q and freq need to be limited withing a reasonable range. In Max, the lowest minimum freq is 10 hz, below that it will blow up.

The other problem is that we divide by Q, without having a minimum value for Q, leading to div-by-0
    @timothyschoen
    timothyschoen committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    f061aad View commit details
    Browse the repository at this point in the history