Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PORT-7618 | Dynatrace Ocean Integration with Invalid Entity Fields #581

Closed
wants to merge 19 commits into from

Conversation

lordsarcastic
Copy link
Contributor

Description

What - Fixed bug affecting Entity blueprints where fields: firstSeenTms, lastSeenTms, and tags; are missing
Why - So bugs won't be in the integration
How - Added query parameters to explicitly fetch these missing fields

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Screenshot 2024-04-17 at 18 40 16

API Documentation

Monitored Entity API

Copy link
Contributor

@PeyGis PeyGis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lordsarcastic for every new updates to the integration, we need to bump the integration version as well as creating changelog for it. This is missing from this PR. Please include them

@github-actions github-actions bot added size/S and removed size/XS labels Apr 23, 2024
Copy link
Collaborator

@yairsimantov20 yairsimantov20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌊

@github-actions github-actions bot added size/XS and removed size/S labels Apr 26, 2024
Copy link
Collaborator

@yairsimantov20 yairsimantov20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments

integrations/dynatrace/client.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/M and removed size/XS labels May 24, 2024
integrations/dynatrace/CHANGELOG.md Outdated Show resolved Hide resolved
integrations/dynatrace/client.py Outdated Show resolved Hide resolved
@lordsarcastic
Copy link
Contributor Author

PR moved to non fork

@lordsarcastic lordsarcastic deleted the port-7618 branch June 25, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants