-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick wins for Ocean #791
base: main
Are you sure you want to change the base?
Quick wins for Ocean #791
Conversation
b75eb6a
to
b6cd380
Compare
integrations/aws/pyproject.toml
Outdated
@@ -14,6 +14,7 @@ types-aioboto3 = "^12.4.0" | |||
types-aiobotocore = {extras = ["sts"], version = "^2.12.3"} | |||
|
|||
[tool.poetry.group.dev.dependencies] | |||
port_ocean = { path = '../../', develop = true, extras = ['all'] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
ab463a1
to
072a2a7
Compare
.vscode/launch.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way to make it more generic? so we won't need to add that for each new integration
c79909d
to
d66a10a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 small change
OCEAN__PORT__CLIENT_SECRET="<port-client-secret>" | ||
OCEAN__EVENT_LISTENER={"type": "POLLING"} | ||
OCEAN__INTEGRATION__IDENTIFIER="my-{{ }}-integration" | ||
OCEAN__INTEGRATION__TYPE="aws" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change from aws?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the thing though, we need it to be one of the default ones for it to actually work on the initial try :(,
the {{ }}
part is a bug though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed + added comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont agree with this one
Lets find a better solution
f6f5710
to
63c66c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super nice 🚀
make sure to bump all versions as we changed dependancies, also you might need to poetry lock them 💡
integrations/aws/poetry.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this by mistake?
- kind: <ResourceName1> | ||
- kind: <ResourceName2> | ||
- kind: {{ cookiecutter.integration_slug }}-example-kind | ||
# - kind: <ResourceName2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to add that as an example of what could be added
- name: myGitToken | ||
required: true | ||
- name: my{{ cookiecutter.integration_slug}}Token | ||
# required: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
port_ocean/cli/commands/new.py
Outdated
@@ -37,6 +56,8 @@ def new(path: str, is_private_integration: bool) -> None: | |||
) | |||
name = result.split("/")[-1] | |||
|
|||
add_vscode_configuration(result, name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets talk about this
OCEAN__PORT__CLIENT_SECRET="<port-client-secret>" | ||
OCEAN__EVENT_LISTENER={"type": "POLLING"} | ||
OCEAN__INTEGRATION__IDENTIFIER="my-{{ }}-integration" | ||
OCEAN__INTEGRATION__TYPE="aws" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont agree with this one
Lets find a better solution
@@ -1,14 +1,14 @@ | |||
description: {{cookiecutter.integration_name}} integration for Port Ocean | |||
icon: Cookiecutter # Should be one of the available icons in Port | |||
icon: Blueprint # Should be one of the available icons in Port | |||
features: | |||
- type: exporter | |||
section: Git Providers # Should be one of the available sections in Port |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a git provider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove for now|
lets find a better solution
@@ -1,14 +1,14 @@ | |||
description: {{cookiecutter.integration_name}} integration for Port Ocean | |||
icon: Cookiecutter # Should be one of the available icons in Port |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert
@@ -19,7 +21,7 @@ towncrier = "^23.6.0" | |||
[tool.towncrier] | |||
directory = "changelog" | |||
filename = "CHANGELOG.md" | |||
package = "port_ocean" | |||
package = "port_ocean.{{cookiecutter.integration_slug}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If u r already here talk to me there is something i want to fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just remove me
8d6f10e
to
1127315
Compare
ad12c49
to
c586ebb
Compare
@@ -1,14 +1,14 @@ | |||
description: {{cookiecutter.integration_name}} integration for Port Ocean | |||
icon: Cookiecutter # Should be one of the available icons in Port | |||
icon: Blueprint # Should be one of the available icons in Port | |||
features: | |||
- type: exporter | |||
section: Git Providers # Should be one of the available sections in Port |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove for now|
lets find a better solution
OCEAN__INTEGRATION__IDENTIFIER="my-{{ cookiecutter.integration_slug }}-integration" | ||
# Change to your integration type once published | ||
OCEAN__INTEGRATION__TYPE="aws" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for us
@@ -0,0 +1,6 @@ | |||
OCEAN__PORT__CLIENT_ID="<port-client-id>" | |||
OCEAN__PORT__CLIENT_SECRET="<port-client-secret>" | |||
OCEAN__EVENT_LISTENER={"type": "POLLING"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im the default
|
||
from port_ocean.cli.commands.main import cli_start, print_logo, console | ||
from port_ocean.cli.utils import cli_root_path | ||
|
||
|
||
def add_vscode_configuration(result: str, name: str) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move me to the make file instead
4e9b218
to
d82ef6e
Compare
* Proper `.env.example` files * Update vscode launch configuration with new generated integration * Add initial static examples to see the integration quickly in Port, including example blueprints and mappings * Add unit test stub
Type of change