Quick wins for Ocean #791

erikzaadi · 2024-07-08T16:36:53Z

Add single integration version bump
Linked dev ocean-core
Precommit that also autoruns lint when we have changes in python files
Fix vscode debug entries
Add cookie cutter to make new integrations up to standards
Add simple unit tests

Type of change

New feature (non-breaking change which adds functionality)

integrations/aws/changelog/.gitignore

Tankilevitch · 2024-07-08T19:21:46Z

integrations/aws/pyproject.toml

@@ -14,6 +14,7 @@ types-aioboto3 = "^12.4.0"
 types-aiobotocore = {extras = ["sts"], version = "^2.12.3"}

 [tool.poetry.group.dev.dependencies]
+port_ocean = { path = '../../', develop = true, extras = ['all'] }


Tankilevitch · 2024-07-14T09:14:50Z

.vscode/launch.json

is there a way to make it more generic? so we won't need to add that for each new integration

matan84

1 small change

matan84 · 2024-07-22T10:18:41Z

port_ocean/cli/cookiecutter/{{cookiecutter.integration_slug}}/.env.example

+OCEAN__PORT__CLIENT_SECRET="<port-client-secret>"
+OCEAN__EVENT_LISTENER={"type": "POLLING"}
+OCEAN__INTEGRATION__IDENTIFIER="my-{{ }}-integration"
+OCEAN__INTEGRATION__TYPE="aws"


Maybe change from aws?

That's the thing though, we need it to be one of the default ones for it to actually work on the initial try :(,
the {{ }} part is a bug though!

Fixed + added comment

I dont agree with this one
Lets find a better solution

Tankilevitch

super nice 🚀
make sure to bump all versions as we changed dependancies, also you might need to poetry lock them 💡

Tankilevitch · 2024-07-27T13:38:45Z

integrations/aws/poetry.lock

is this by mistake?

Tankilevitch · 2024-07-27T13:40:59Z

port_ocean/cli/cookiecutter/{{cookiecutter.integration_slug}}/.port/spec.yaml

-      - kind: <ResourceName1>
-      - kind: <ResourceName2>
+      - kind: {{ cookiecutter.integration_slug }}-example-kind
+      # - kind: <ResourceName2>


I wanted to add that as an example of what could be added

Tankilevitch · 2024-07-27T13:41:04Z

port_ocean/cli/cookiecutter/{{cookiecutter.integration_slug}}/.port/spec.yaml

-  - name: myGitToken
-    required: true
+  - name: my{{ cookiecutter.integration_slug}}Token
+    # required: true


yairsimantov20 · 2024-07-29T07:45:32Z

port_ocean/cli/commands/new.py

@@ -37,6 +56,8 @@ def new(path: str, is_private_integration: bool) -> None:
    )
    name = result.split("/")[-1]

+    add_vscode_configuration(result, name)


Lets talk about this

yairsimantov20 · 2024-07-29T07:46:28Z

port_ocean/cli/cookiecutter/{{cookiecutter.integration_slug}}/.env.example

+OCEAN__PORT__CLIENT_SECRET="<port-client-secret>"
+OCEAN__EVENT_LISTENER={"type": "POLLING"}
+OCEAN__INTEGRATION__IDENTIFIER="my-{{ }}-integration"
+OCEAN__INTEGRATION__TYPE="aws"


I dont agree with this one
Lets find a better solution

yairsimantov20 · 2024-07-29T07:46:58Z

port_ocean/cli/cookiecutter/{{cookiecutter.integration_slug}}/.port/spec.yaml

@@ -1,14 +1,14 @@
 description: {{cookiecutter.integration_name}} integration for Port Ocean
-icon: Cookiecutter # Should be one of the available icons in Port
+icon: Blueprint # Should be one of the available icons in Port
 features:
  - type: exporter
    section: Git Providers # Should be one of the available sections in Port


Is it a git provider?

remove for now|
lets find a better solution

yairsimantov20 · 2024-07-29T07:47:19Z

port_ocean/cli/cookiecutter/{{cookiecutter.integration_slug}}/.port/spec.yaml

@@ -1,14 +1,14 @@
 description: {{cookiecutter.integration_name}} integration for Port Ocean
-icon: Cookiecutter # Should be one of the available icons in Port


yairsimantov20 · 2024-07-29T07:48:22Z

port_ocean/cli/cookiecutter/{{cookiecutter.integration_slug}}/pyproject.toml

@@ -19,7 +21,7 @@ towncrier = "^23.6.0"
 [tool.towncrier]
 directory = "changelog"
 filename = "CHANGELOG.md"
-package = "port_ocean"
+package = "port_ocean.{{cookiecutter.integration_slug}}"


If u r already here talk to me there is something i want to fix

just remove me

yairsimantov20 · 2024-08-13T10:08:39Z

port_ocean/cli/cookiecutter/{{cookiecutter.integration_slug}}/.port/spec.yaml

@@ -1,14 +1,14 @@
 description: {{cookiecutter.integration_name}} integration for Port Ocean
-icon: Cookiecutter # Should be one of the available icons in Port
+icon: Blueprint # Should be one of the available icons in Port
 features:
  - type: exporter
    section: Git Providers # Should be one of the available sections in Port


remove for now|
lets find a better solution

yairsimantov20 · 2024-08-13T10:10:34Z

port_ocean/cli/cookiecutter/{{cookiecutter.integration_slug}}/.env.example

+OCEAN__INTEGRATION__IDENTIFIER="my-{{ cookiecutter.integration_slug }}-integration"
+# Change to your integration type once published
+OCEAN__INTEGRATION__TYPE="aws"


no need for us

yairsimantov20 · 2024-08-13T10:10:46Z

port_ocean/cli/cookiecutter/{{cookiecutter.integration_slug}}/.env.example

@@ -0,0 +1,6 @@
+OCEAN__PORT__CLIENT_ID="<port-client-id>"
+OCEAN__PORT__CLIENT_SECRET="<port-client-secret>"
+OCEAN__EVENT_LISTENER={"type": "POLLING"}


im the default

yairsimantov20 · 2024-08-13T10:13:43Z

port_ocean/cli/commands/new.py


 from port_ocean.cli.commands.main import cli_start, print_logo, console
 from port_ocean.cli.utils import cli_root_path


+def add_vscode_configuration(result: str, name: str) -> None:


move me to the make file instead

* Proper `.env.example` files * Update vscode launch configuration with new generated integration * Add initial static examples to see the integration quickly in Port, including example blueprints and mappings * Add unit test stub

github-actions bot added size/L size/XL and removed size/L labels Jul 8, 2024

erikzaadi force-pushed the PORT-9072 branch 2 times, most recently from b75eb6a to b6cd380 Compare July 8, 2024 19:10

Tankilevitch reviewed Jul 8, 2024

View reviewed changes

erikzaadi force-pushed the PORT-9072 branch 3 times, most recently from ab463a1 to 072a2a7 Compare July 14, 2024 08:14

Tankilevitch reviewed Jul 14, 2024

View reviewed changes

.vscode/launch.json Outdated

Copy link

Contributor

Tankilevitch Jul 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to make it more generic? so we won't need to add that for each new integration

erikzaadi force-pushed the PORT-9072 branch 3 times, most recently from c79909d to d66a10a Compare July 22, 2024 10:11

matan84 requested changes Jul 22, 2024

View reviewed changes

erikzaadi force-pushed the PORT-9072 branch 5 times, most recently from f6f5710 to 63c66c1 Compare July 25, 2024 11:15

Tankilevitch approved these changes Jul 27, 2024

View reviewed changes

yairsimantov20 requested changes Jul 29, 2024

View reviewed changes

erikzaadi force-pushed the PORT-9072 branch 2 times, most recently from 8d6f10e to 1127315 Compare August 13, 2024 06:26

github-actions bot added size/XXL and removed size/XL labels Aug 13, 2024

erikzaadi force-pushed the PORT-9072 branch 5 times, most recently from ad12c49 to c586ebb Compare August 13, 2024 09:16

yairsimantov20 reviewed Aug 13, 2024

View reviewed changes

erikzaadi force-pushed the PORT-9072 branch 2 times, most recently from 4e9b218 to d82ef6e Compare August 18, 2024 12:14

erikzaadi added 5 commits August 19, 2024 11:37

Proper vscode debug integration entries

c58db21

Single integration version bump + pre-commit hooks

9312e77

Update cookiecutter to integration standards

004c7d4

* Proper `.env.example` files * Update vscode launch configuration with new generated integration * Add initial static examples to see the integration quickly in Port, including example blueprints and mappings * Add unit test stub

Add unit test support

4e56684

Update all integrations with debug link information

aeb93e9

erikzaadi force-pushed the PORT-9072 branch from d82ef6e to aeb93e9 Compare August 19, 2024 08:37

erikzaadi requested a review from a team as a code owner August 19, 2024 08:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Quick wins for Ocean #791

Quick wins for Ocean #791

erikzaadi commented Jul 8, 2024 •

edited

Loading

Tankilevitch Jul 8, 2024

erikzaadi Jul 11, 2024

Tankilevitch Jul 14, 2024

matan84 left a comment

matan84 Jul 22, 2024

erikzaadi Jul 22, 2024

erikzaadi Jul 22, 2024 •

edited

Loading

yairsimantov20 Jul 29, 2024

Tankilevitch left a comment •

edited

Loading

Tankilevitch Jul 27, 2024

Tankilevitch Jul 27, 2024

erikzaadi Aug 13, 2024

Tankilevitch Jul 27, 2024

erikzaadi Aug 13, 2024

yairsimantov20 Jul 29, 2024

yairsimantov20 Jul 29, 2024

yairsimantov20 Jul 29, 2024

yairsimantov20 Aug 13, 2024

yairsimantov20 Jul 29, 2024

yairsimantov20 Aug 13, 2024

yairsimantov20 Jul 29, 2024

yairsimantov20 Aug 13, 2024

yairsimantov20 Aug 13, 2024

yairsimantov20 Aug 13, 2024

yairsimantov20 Aug 13, 2024

yairsimantov20 Aug 13, 2024

		@@ -1,14 +1,14 @@
		description: {{cookiecutter.integration_name}} integration for Port Ocean
		icon: Cookiecutter # Should be one of the available icons in Port

Quick wins for Ocean #791

Are you sure you want to change the base?

Quick wins for Ocean #791

Conversation

erikzaadi commented Jul 8, 2024 • edited Loading

Type of change

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matan84 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

erikzaadi Jul 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tankilevitch left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

erikzaadi commented Jul 8, 2024 •

edited

Loading

erikzaadi Jul 22, 2024 •

edited

Loading

Tankilevitch left a comment •

edited

Loading