Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integration][AWS] bug aws integration stops resync after access denied #810

Merged

Conversation

shalev007
Copy link
Contributor

  • feat: add access denied exception support
  • feat: bump version

Description

What - handle access denied errors from AWS
Why - in case there is no permission to read resources in certain regions we need to keep reading from other regions
How - add try-catch boundaries

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

@shalev007 shalev007 changed the title PORT 9167 bug aws integration stops resync after access denied [Integration][AWS] bug aws integration stops resync after access denied Jul 11, 2024
Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just make sure to update the suggested changes

integrations/aws/utils/resources.py Outdated Show resolved Hide resolved
integrations/aws/utils/resources.py Outdated Show resolved Hide resolved
@shalev007 shalev007 merged commit bcd2d6c into main Jul 11, 2024
7 checks passed
@shalev007 shalev007 deleted the PORT-9167-bug-aws-integration-stops-resync-after-access-denied branch July 11, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants