Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Integration][Kubecost] Kubecost integration fetch data error #901

Merged
merged 5 commits into from
Aug 14, 2024
Merged

[Integration][Kubecost] Kubecost integration fetch data error #901

merged 5 commits into from
Aug 14, 2024

Conversation

lordsarcastic
Copy link
Contributor

Description

What - Fixed NoneType error when fetching cloudcost data
Why -
How -

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)

PeyGis
PeyGis requested changes Aug 14, 2024
View reviewed changes
integrations/kubecost/main.py Outdated Show resolved Hide resolved
PeyGis
PeyGis approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@PeyGis PeyGis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@Tankilevitch Tankilevitch merged commit c246f65 into main Aug 14, 2024
11 checks passed
@Tankilevitch Tankilevitch deleted the port-9244 branch August 14, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeyGis PeyGis PeyGis approved these changes

@Tankilevitch Tankilevitch Tankilevitch approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lordsarcastic @PeyGis @Tankilevitch