Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate Message IDs in message.hpp #484

Closed
gerryk opened this issue Jan 28, 2022 · 1 comment
Closed

Duplicate Message IDs in message.hpp #484

gerryk opened this issue Jan 28, 2022 · 1 comment
Labels
Bug Something isn't working

Comments

@gerryk
Copy link

gerryk commented Jan 28, 2022

Describe the bug
The following IDs are seen in https://github.com/eried/portapack-mayhem/blob/next/firmware/common/message.hpp

		FSKConfigure = 43,
		SSTVConfigure = 44,
		SigGenConfig = 43,
		SigGenTone = 44,

This seems incorrect.

To Reproduce
n/a

Expected behavior
n/a

Affected versions
all up to 1.4.2

Additional
@gerryk gerryk added the Bug Something isn't working label Jan 28, 2022
@ArjanOnwezen ArjanOnwezen mentioned this issue Mar 20, 2022
Merged
eried added a commit that referenced this issue Mar 21, 2022
@eried
Merge pull request #506 from ArjanOnwezen/#484-add-consecutive-ids-in…
901af22 
…-message.hpp

Added consecutive id's in message.hpp, as mentioned in #484.
@ArjanOnwezen
Copy link
Contributor

Available on Next branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gerryk @ArjanOnwezen