XOR cursor support in Notepad #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kallanreed
reviewed
Jul 27, 2023
kallanreed
reviewed
Jul 27, 2023
kallanreed
reviewed
Jul 27, 2023
kallanreed
reviewed
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Notepad enhancement suggestion #1310, I found the text under the cursor almost unreadable in the 5x8 Notepad font since the cursor rectangle was right up against the character pixels. I tried different rectangle colors for the "box" style cursor, but it didn't help. I find this XOR cursor to be much more readable. Compare the cursor in the following BEFORE & AFTER screen-shot examples:
BEFORE (the 0 under the cursor looks kinda like an X, not sure):
AFTER (the pixel colors are inverted [XOR'd] under the cursor, and clearly a 0):
