Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert encoder sensitivity change #1314

Merged
merged 5 commits into from
Jul 27, 2023

Conversation

NotherNgineer
Copy link
Contributor

@NotherNgineer NotherNgineer commented Jul 27, 2023

Revert the encoder dial sensitivity change #1275 to match the behavior of v1.7.3 release (e.g. only 3 settings, and "normal" meaning one step per dial click). It didn't help the original issue it was meant for, and the "normal" setting unexpectedly didn't behave like the original "normal" setting.

This change requires a pMem version increase (users upgrading from 1.7.3 to 1.7.4. will all get their pMem reset to defaults anyway due to an earlier change).

@NotherNgineer NotherNgineer marked this pull request as ready for review July 27, 2023 13:08
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gullradriel gullradriel merged commit e7c5a86 into portapack-mayhem:next Jul 27, 2023
3 checks passed
@NotherNgineer NotherNgineer deleted the revert-encoder branch July 30, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants