fix shift back in screenshot and mayhem hub #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxkmm
requested review from
u-foka,
gullradriel,
jLynx,
NotherNgineer and
jimilinuxguy
NotherNgineer
approved these changes
Feb 17, 2024
|
Thank you again! 💕 @NotherNgineer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix shift back in screenshot and mayhem hub to prevent it getting extremely darken in these features.
@NotherNgineer sorry that actually, after checking, the color didn't seem lost when shifting back.
When i testing, i shifted back in same func, and it seems lost some color.
I didn't know why (shifting back in same func would lost some accurate) and why not (shift back in read func won't lose some accurate) yet, but this one works.
Either way, this is the best result (accurate lost is barely invisible or didn't lose) anyway.
also this PR fixed the cursor issue previously in notepad. so it's safe now to remove the temp and not elegange workaround for it
test fw
https://discord.com/channels/719669764804444213/722101917135798312/1208287497348714596