Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shift back in screenshot and mayhem hub #1910

Merged

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Feb 17, 2024

fix shift back in screenshot and mayhem hub to prevent it getting extremely darken in these features.

@NotherNgineer sorry that actually, after checking, the color didn't seem lost when shifting back.
When i testing, i shifted back in same func, and it seems lost some color.
I didn't know why (shifting back in same func would lost some accurate) and why not (shift back in read func won't lose some accurate) yet, but this one works.
Either way, this is the best result (accurate lost is barely invisible or didn't lose) anyway.

also this PR fixed the cursor issue previously in notepad. so it's safe now to remove the temp and not elegange workaround for it

test fw
https://discord.com/channels/719669764804444213/722101917135798312/1208287497348714596

@zxkmm zxkmm marked this pull request as ready for review February 17, 2024 05:15
@zxkmm zxkmm merged commit 948e039 into portapack-mayhem:next Feb 17, 2024
3 checks passed
@zxkmm zxkmm deleted the f_brightness_reading_data_workaround branch February 17, 2024 16:44
@zxkmm
Copy link
Contributor Author

zxkmm commented Feb 17, 2024

Thank you again! 💕 @NotherNgineer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants