Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level app: coloration of RxSat value #1969

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

gullradriel
Copy link
Member

That PR add a coloration of the whole "RxSat: XXX%" string, with the following rules:

  • 80% of sat is the ideal value
  • RxSat <= 80 => gradient from (rxSat 0,red) to (rxSat 80,green)
  • RxSat > 80 => gradient from (rxSat 80,green) to (rxSat 100,red)
    ## Screenshots
    imageimageimage

Copy link
Contributor

@NotherNgineer NotherNgineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a few minor comments: The blue is a little hard to see (without any R & G mixed in for brightness), and I might suggest moving the "percent to color gradient" calculation code to its own function.

@gullradriel
Copy link
Member Author

Okay, I changed the way it's displayed.
That's the best I got:
imageimageimage

@gullradriel gullradriel merged commit 2ac36d2 into portapack-mayhem:next Mar 10, 2024
3 checks passed
@gullradriel
Copy link
Member Author

"percent to color gradient" calculation code to its own function => we may need generic ones like in P5.js
I'm keeping the idea under the hat

@gullradriel gullradriel deleted the level-rxsat-color branch March 10, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants