Deallocate menu buttons to save memory #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gullradriel
approved these changes
Mar 10, 2024
|
The Capture app hangs frequently starting with nightly n_240311. This PR is the most likely cause. @u-foka FYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code from @u-foka to deallocate memory for menu buttons that are not currently visible on the screen (i.e. when opening a sub-menu or an app), as suggested in issue #1914.
(Each menu button consumes about 300 bytes, so deallocating 10 of them, for example, saves about 3KB.)
Thanks to @u-foka.
Test version here:
https://discord.com/channels/719669764804444213/722101917135798312/1216473993113112636