Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Audio app, update iq_phase_cal in radio when starting SPEC mode #1972

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

NotherNgineer
Copy link
Contributor

@NotherNgineer NotherNgineer commented Mar 10, 2024

The iq_phase_calibration value from the .ini file was not being programmed into the radio when starting Spec mode in the Audio app, therefore it was only taking effect if the user changed the value while SPEC mode was running.

Fixes this minor issue in PR #1963, per @Brumi-2021

Test version here:
https://discord.com/channels/719669764804444213/722101917135798312/1216473993113112636

@NotherNgineer NotherNgineer marked this pull request as ready for review March 10, 2024 19:45
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch !
Thanks @Brumi-2021 & @NotherNgineer :-)

@gullradriel gullradriel merged commit ccd71d9 into portapack-mayhem:next Mar 10, 2024
3 checks passed
@Brumi-2021
Copy link
Contributor

Thanks to both ! @NotherNgineer @gullradriel

I have already validated your test binary , in both r6 (max2837 ) , r9 (max2839) and now it works in both flawlessly .
Now , at first booting follows exactly the saved rx_iq_phase_error_cal value in the rx_audio.ini. (tested with uncalibrated / calibrated manual input data) .

Note : as far as I can see , good default data for r6 (max2837 ) is around 13 or 15 /31 , , r9 (max2839) 25 to 31 /63
(so if you can not find a proper set up to calibrate it , you can use a middle value of the range as a good default ).

Thanks

@gullradriel
Copy link
Member

How different is a IQ good value tunes signal vs a RxSat good value tuned one ?

@gullradriel
Copy link
Member

Ho I see. It's different, it's image rejection.
I have to see if it can help the looking glass !

@gullradriel
Copy link
Member

Ho my god !
It helps a lot in looking glass, nearly killing the ghost when capturing a keyfob @ 868MHZ !!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants