Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record gps lat, lon, satinuse from recorder app if there was gps signal. #1992

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

htotoo
Copy link
Member

@htotoo htotoo commented Mar 14, 2024

Added the ability to Recorder to store GPS data with recordings.
If an external GPS module present and sent valid data while the app was open (before start recording) it stores the latitude, longitude, and sats in use data to the metadata file (txt).

If the recording has GPS data, the filename will be appended with _GEO, so users will notice, if they share it, it can have sensitive data.

If you record multiple signals, and the GPS module works fine, each recording will have the latest gps data.

This PR is only to store the coordinates, no display!
Great for wardriving.

Requested here:
#1966

For that issue, there could be an external app that loads the TXTs from capture folder, and what file has coordinates, those could be added to a map. I don't wanted to integrate this to any exists app, not to confuse users without ext GPS.

@htotoo
Copy link
Member Author

htotoo commented Mar 14, 2024

EDIT: problem solved with different filename.

Comment was before:
Before accept, consider an other option, to store the geo data to a separated file like CAPTURE016.geo to prevent users to accidentally share sensitive data.

Both methods have advantages and disadvantages.

Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once the conversation is resolved :-)

@zxkmm zxkmm merged commit 9e40e38 into portapack-mayhem:next Mar 15, 2024
3 checks passed
@htotoo htotoo deleted the wardrive branch March 19, 2024 10:45
@htotoo htotoo mentioned this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants