Stop audio DMA in baseband::shutdown() #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a longstanding issue that the audio DMA engines, once started, continued to run freely after baseband::shutdown() was called. It wasn't as much of an issue before PR's #1982 and #1987 because all background processes were starting both audio-input and audio-output DMA engines and letting them run forever.
This issue was causing the Microphone app to crash when switching between baseband processes that perform DMA operations in different directions.
Fixes #1998
Test firmware available here: https://discord.com/channels/719669764804444213/722101917135798312/1219496508400078899