Improved audio beep tone #2014
Merged
Improved audio beep tone #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gullradriel
approved these changes
Mar 19, 2024
|
Now I just have to wait for some weather balloon to fly over. :-) |
|
I need to add this in Level app, the beeeeep !!! |
|
FYI, I will have another fix coming for the beep when clicking the Beep checkbox in the Sonde app. Currently the "request_beep" function only makes a sound if the RSSI level is high enough, so I'll need to modify that baseband message to allow beeps of any audio frequency regardless of RSSI level. |
|
@NotherNgineer Eres un genio, gracias por todo el trabajo, cada día entro para ver tus obras maestras. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved audio quality of RSSI beep tone.
Explanation example: Audio DMA uses a 128-sample buffer. For a 1KHz tone and a 24KHz sample rate, each sine wave has 24 samples. But 128/24 = 5.3333, i.e. 5 full sine waves plus a partial wave.
Instead of always sending 128 samples to the audio chip, this PR tweaks the number of samples to eliminate sending that partial sine wave which was causing distortion. In the above example, 5 complete sine waves (5 x 24 samples) will be sent instead of 5.333 sine waves.