Radiosonde QR code fixes #2021
Merged
Radiosonde QR code fixes #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotherNgineer
changed the title
NotherNgineer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed QR code issue when lat or lon was 0 degrees. QR code URI was missing the 0 digit to the left of decimal point. Now uses our standard function for float-to-string conversion, which doesn't have that problem.
Fixed QR code to display the most recent packet's lat/lon coordinates (versus the previous packet's coordinates).
Changed the "See QR" and "See on map" buttons to show the lat/lon location indicated on the screen. This is usually the same as the coordinates from the last packet, but the user might have changed them manually since the last packet was received. Now a QR code can be generated for any user-specified coordinates.
Now using 4 pixels, versus 1 pixel, for every black dot in the "small" (type 10) location QR code for easier scanning (less of a challenge to focus). Tested on Android & iPhone.
Deprecate support for the "large" (type 2 low resolution) QR code, which did not work (since i-dunno-when) per testing on iPhone & Android, and is no longer needed since the "small" QR code is now 4X larger. Saves 2KB of ROM space.
Test firmware available here: https://discord.com/channels/719669764804444213/722101917135798312/1220402124714676254