Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Level fix and beep, RSSI avg fix #2027

Merged
merged 9 commits into from
Mar 23, 2024
Merged

Level fix and beep, RSSI avg fix #2027

merged 9 commits into from
Mar 23, 2024

Conversation

gullradriel
Copy link
Member

@gullradriel gullradriel commented Mar 23, 2024 •
edited
Loading

RSSI:

  • a previous change to accumulator variable made it useless and overflowing. This is the message.hpp fix.

Level:

  • fixed audio lost on mode changes
  • added beep based on db level in spec mode when audio is on

@gullradriel
Copy link
Member Author

Poke @NotherNgineer it seem's I can't beep in Level and SPEC.
Can you help me please ?

@gullradriel gullradriel added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Mar 23, 2024
@gullradriel gullradriel marked this pull request as ready for review March 23, 2024 15:24
@gullradriel
Copy link
Member Author

Test bin in discord

@gullradriel
Copy link
Member Author

Thanks @NotherNgineer for your precise help ;-)

@gullradriel gullradriel removed help wanted Extra attention is needed question Further information is requested labels Mar 23, 2024
NotherNgineer
NotherNgineer approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@NotherNgineer NotherNgineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gullradriel gullradriel merged commit 5369819 into portapack-mayhem:next Mar 23, 2024
3 checks passed
@gullradriel gullradriel deleted the level-fix-and-beep branch March 23, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotherNgineer NotherNgineer NotherNgineer approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gullradriel @NotherNgineer