Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert accidental button color changes #2029

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

NotherNgineer
Copy link
Contributor

@NotherNgineer NotherNgineer commented Mar 23, 2024

  1. Revert accidental change of NewButton default background color (should have been grey but was set to light_grey accidentally in PR Support for configurable Menu Color & scrolling fix #1905 right before the 2.0.0 firmware release)

  2. Revert some of the foreground color changes in FileMan that were made in PR Modified FileMan button colors for visibility #2010 to compensate for the error in PR Support for configurable Menu Color & scrolling fix #1905.

This change restores the NewButton backgound color in FileMan, FreqMan, Replay, Remote, and Notepad apps. The original grey was a better background color because there is more contrast when the button is selected; with the light_grey background it was more difficult to see certain icon colors and not as obvious which button was selected.

Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go for it ;-)

@NotherNgineer NotherNgineer merged commit 1a87f2d into portapack-mayhem:next Mar 23, 2024
3 checks passed
@NotherNgineer NotherNgineer deleted the newbutton branch March 23, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants