Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking glass beep #2036

Merged
merged 6 commits into from
Mar 24, 2024
Merged

Conversation

gullradriel
Copy link
Member

@gullradriel gullradriel commented Mar 24, 2024

This add a squelch based beep option on Looking Glass:

  • It can be enabled/disabled
  • Squelch level before activating beep is adjustable
  • Detection use the whole range
  • In order to add the necessary volume field, I took out the (IMHO) not useful 'STEPS'

Can be seen here:
https://discord.com/channels/719669764804444213/738371118204846131/1221545809179578418

Test bin here:
https://discord.com/channels/719669764804444213/722101917135798312/1221552584704135219

@gullradriel gullradriel added the enhancement New feature or request label Mar 24, 2024
@gullradriel gullradriel marked this pull request as ready for review March 24, 2024 20:16
@gullradriel
Copy link
Member Author

That 'map' function I added should be templated somewhere, or maybe it already exists in the firmware ?
I don't know how, so I duplicated it for now.
I or someone else will update this in a future PR.

Copy link
Contributor

@NotherNgineer NotherNgineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, you might need to check your beep frequencies to see if they still sound good after changing the sampling rate.

@gullradriel
Copy link
Member Author

BTW, you might need to check your beep frequencies to see if they still sound good after changing the sampling rate.

Yes, thanks I did it. It's bit less high, but not bad. Time will tell if we need to adjust the map, but it should be good for a start :-)

@gullradriel gullradriel merged commit c078bac into portapack-mayhem:next Mar 24, 2024
3 checks passed
@gullradriel gullradriel deleted the looking-glass-beep branch March 24, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants