Declare all folder names in a single source file #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gullradriel
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declare all folder paths in one file (clean-up, and to make the changes simpler if we opt to change folder paths in the future in spite of my compatibility concerns).
Also, all paths are now declared using type std::filesystem:path (this actually consumes more ROM space versus simple char strings, but technically it's the more proper type for file paths).
(Ideally) this PR should cause no functional change from a user perspective.
I recommend reviewing the new file "file_path.cpp" first.
Test firmware on discord:
https://discord.com/channels/719669764804444213/722101917135798312/1221706419569426472