-
-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move the no ext app tile to forward #2047
move the no ext app tile to forward #2047
Conversation
I like the added exclamation point to "Notice!" but I don't think the "External apps missing" text is going to reduce the number of confused users plus I don't like that it's hiding the title bar icons. |
I like the latest edition of this pr |
It would help if you could add a screenshot to the PR or put test version on Discord. I would like to see what the updated screen looks like (I'll build it myself but it will take a bit longer) |
Ohhhh wait, no need to build, I'll upload the test bin now. Sorry |
test fw: https://discord.com/channels/719669764804444213/721387120421240872/1222912715635294229 I removed the icon of this tile, cuz i think this can make it more noticeable Sorry that i was just thinking this kind of small change ain't need tests |
I was planning to attract as much attention as possible, but if you think we don't need them, i can remove.
Thanks! I'll fix that now. I forgot that part. |
Back button fixed. |
I don't know if we need to take a vote on this, but personally I think it looks better without the <> as in the screenshot below, so I would remove them: |
No need to vote for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you! |
Move the ext app missing hint tile forward.
maybe can do same with flash err msg (but i won't do it).
Feel free to comment if you think this is not necessary. :)