Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beep-on-packets support in Settings, ERT & Sonde apps #2058

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

NotherNgineer
Copy link
Contributor

@NotherNgineer NotherNgineer commented Mar 28, 2024

  1. Added "Beep on RX Packets" setting under Settings -> Audio as discussed in Add beep option to other apps #2053 (setting to be stored in pmem).
  2. Modified Radiosonde app to use the above setting (eliminating Beep checkbox in Radiosonde app itself -- to avoid conflicting settings).
  3. Added beep support to ERT app (including volume control).

Note: If Beep is desired in some apps but not in others, set "Beep on RX Packets" to True, and turn down the volume to 0 in apps where the beep is not wanted.

(Support for beep-on-RX-packet in other apps to follow in separate PR's)

This PR should not affect beep settings in the the Level and Looking Glass apps (technically these apps are not even looking for "packets").

SCR_0091

Test firmware on Discord: https://discord.com/channels/719669764804444213/722101917135798312/1223324351667896450

@gullradriel
Copy link
Member

Sounds good. Do you prefer to do some separated PR's for the on packet beep support?

@NotherNgineer NotherNgineer marked this pull request as draft March 29, 2024 14:06
@NotherNgineer
Copy link
Contributor Author

Sounds good. Do you prefer to do some separated PR's for the on packet beep support?

If it sounds good, I'll go ahead and add beep support to some apps in this PR. I've changed it to a Draft until then. Thanks.

@NotherNgineer NotherNgineer changed the title Beep-on-packets option in Settings (no app support yet) Beep-on-packets option in Settings and updated ERT & Sonde apps Mar 29, 2024
@NotherNgineer NotherNgineer marked this pull request as ready for review March 29, 2024 17:18
@NotherNgineer
Copy link
Contributor Author

I've updated this PR to include ERT and Radiosonde support for this new "Beep on RX packet" setting, and marked the PR "ready to review". To avoid making this PR any larger, I propose to implement beep-on-packet support in additional apps in future follow-on PR's.

Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :-)

@gullradriel gullradriel merged commit fe2fbb8 into portapack-mayhem:next Mar 29, 2024
3 checks passed
@NotherNgineer NotherNgineer deleted the beep-on-packets branch March 29, 2024 19:43
@NotherNgineer NotherNgineer changed the title Beep-on-packets option in Settings and updated ERT & Sonde apps Beep-on-packets support in Settings, ERT & Sonde apps Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants