Beep-on-packets support in Settings, ERT & Sonde apps #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good. Do you prefer to do some separated PR's for the on packet beep support? |
If it sounds good, I'll go ahead and add beep support to some apps in this PR. I've changed it to a Draft until then. Thanks. |
NotherNgineer
changed the title
|
I've updated this PR to include ERT and Radiosonde support for this new "Beep on RX packet" setting, and marked the PR "ready to review". To avoid making this PR any larger, I propose to implement beep-on-packet support in additional apps in future follow-on PR's. |
NotherNgineer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: If Beep is desired in some apps but not in others, set "Beep on RX Packets" to True, and turn down the volume to 0 in apps where the beep is not wanted.
(Support for beep-on-RX-packet in other apps to follow in separate PR's)
This PR should not affect beep settings in the the Level and Looking Glass apps (technically these apps are not even looking for "packets").
Test firmware on Discord: https://discord.com/channels/719669764804444213/722101917135798312/1223324351667896450