Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small fonts in theme code #2222

Merged

Conversation

NotherNgineer
Copy link
Contributor

@NotherNgineer NotherNgineer commented Aug 14, 2024

The "themes" code (in PR #2166) was incorrectly displaying "bg_lightest_small" text in large font, versus small.

This issue is visible in stack dumps (when DFU button is pressed following a fault), as in this photo:
Screenshot at 2024-08-14 11-49-54

I also removed some unnecessary "ui::" just for consistency.

Copy link
Contributor

@Brumi-2021 Brumi-2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it looks like correct ,
amending the previous too big font size definition in the light_white_background_font_size.

Accidentally we found it in the gcc 13.2.1 debugging investigation .
It should be fine.

@Brumi-2021 Brumi-2021 merged commit 750d592 into portapack-mayhem:next Aug 14, 2024
3 checks passed
@NotherNgineer NotherNgineer deleted the theme-fix-small-font branch September 7, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants