Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit 50 items per page in sndboard. Maybe solves oom #2263

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

htotoo
Copy link
Member

@htotoo htotoo commented Sep 23, 2024

Bug that this pr fixes #2262

This may fix, needs testing with 100+ valid wav files in /WAV folder.

@htotoo
Copy link
Member Author

htotoo commented Sep 23, 2024

waiting for feedback. maybe need to lower the limit a bit.

@htotoo htotoo marked this pull request as ready for review September 24, 2024 10:33
@htotoo htotoo enabled auto-merge (squash) September 24, 2024 10:34
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway it's better with 50 per page ;-)

@htotoo htotoo merged commit b3a0ad0 into portapack-mayhem:next Sep 28, 2024
3 checks passed
@htotoo htotoo deleted the sndmem branch September 28, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

M0 Guru Meditation - “Hint: Out of Memory”
2 participants