Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting&autostart&widgets (OptionField and Waveform) imp #2286

Merged
merged 5 commits into from
Oct 6, 2024
Merged

setting&autostart&widgets (OptionField and Waveform) imp #2286

merged 5 commits into from
Oct 6, 2024

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Oct 6, 2024 •
edited
Loading

changes

  • ad a center option for OptionField class, that when you create obj, you can make it centered.
  • fix the crash that you seted a external app as auto start, but not exist or outdated.
  • fix Waveform class is upside dowm.
  • add reset for auto start option in setting app cuz it’s hard to reset.

space usage

no much differences:
Space remaining in flash ROM: 7192 bytes ( 0.7 %)

@zxkmm zxkmm marked this pull request as ready for review October 6, 2024 14:46
@zxkmm zxkmm changed the title setting&autotart&widget imp setting&autotart&widgets (OptionField and Waveform) imp Oct 6, 2024
@zxkmm zxkmm changed the title setting&autotart&widgets (OptionField and Waveform) imp setting&autostart&widgets (OptionField and Waveform) imp Oct 6, 2024
@zxkmm zxkmm enabled auto-merge (squash) October 6, 2024 15:10
gullradriel
gullradriel approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'm going to ping you back if it's not ;-)

@zxkmm zxkmm merged commit d4edb5f into portapack-mayhem:next Oct 6, 2024
3 checks passed
@Brumi-2021 Brumi-2021 mentioned this pull request Nov 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gullradriel gullradriel gullradriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxkmm @gullradriel