Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External module api #2290

Merged
merged 14 commits into from
Oct 14, 2024

Conversation

bernd-herzog
Copy link
Contributor

This pull requests adds the external module api

@bernd-herzog
Copy link
Contributor Author

This pull requests is still work in progress

@gullradriel
Copy link
Member

I love what's coming , many thanks to you !

@bernd-herzog
Copy link
Contributor Author

the sources for the standalone app and the esp32 firmware can for now be found at: https://github.com/bernd-herzog/mayhem-external-module/tree/external-module-api

@bernd-herzog
Copy link
Contributor Author

I created a new repository in the mayhem organization with a nice name: PortaPack - Module Develoment Kit
https://github.com/portapack-mayhem/mayhem-mdk

@gullradriel
Copy link
Member

Good idea !
Maybe @htotoo can do the same for his USB serial stuff ?

@bernd-herzog bernd-herzog marked this pull request as ready for review October 14, 2024 09:17
Copy link
Contributor

@jLynx jLynx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here!

@gullradriel
Copy link
Member

Just for the record and the history, why I do not like "pragma once"

Platforms/Compilers Known Not to Support #pragma once:

  • Turbo C++ (classic versions)
  • Watcom C++ (older versions)
  • Borland C++ (classic versions, although newer Embarcadero C++ Builder supports it)

Some older or niche embedded systems compilers may not support #pragma once, or it may be inconsistent:

  • Microchip MPLAB XC in older versions.
  • Keil C51, an older compiler for 8051 microcontrollers, doesn’t support it.

Older versions of GCC and Clang:

  • Extremely outdated versions of GCC (pre-3.4, released before 2004) and Clang may lack full or reliable support.

And this has bitten me a few times:

  • Compilers using #pragma once rely on the assumption that files have unique paths. Network file systems, file systems with symbolic links, or certain virtualized environments (like those in cloud builds or CI/CD environments) can cause problems, as #pragma once can get confused by symlinks or different paths to the same file.

Last, some compilers not adhering to modern C++ standards (before C++98) may lack support.

That aside, pretty good job :-)

@bernd-herzog bernd-herzog merged commit dcaa02c into portapack-mayhem:next Oct 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants