-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External module api #2290
External module api #2290
Conversation
# Conflicts: # firmware/application/apps/ui_debug.cpp
This pull requests is still work in progress |
I love what's coming , many thanks to you ! |
the sources for the standalone app and the esp32 firmware can for now be found at: https://github.com/bernd-herzog/mayhem-external-module/tree/external-module-api |
I created a new repository in the mayhem organization with a nice name: PortaPack - Module Develoment Kit |
Good idea ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work here!
Just for the record and the history, why I do not like "pragma once" Platforms/Compilers Known Not to Support #pragma once:
Some older or niche embedded systems compilers may not support #pragma once, or it may be inconsistent:
Older versions of GCC and Clang:
And this has bitten me a few times:
Last, some compilers not adhering to modern C++ standards (before C++98) may lack support. That aside, pretty good job :-) |
This pull requests adds the external module api