Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fine tune waveform and ook again #2322

Merged
merged 9 commits into from
Nov 3, 2024

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Oct 28, 2024

  • add padding in OOK app's waveform to display correct data (start with low level and end with low level), won't impact actual wf that been sent
  • my previous waveform tune edited analog wf's logic, no need, so reverted.
  • now: for digital wf, low level is on the bottom and high level is on top. for analog waveform, greater number is on higher and lower number is on lower.

1527 SymField is broken, but it's not from all of my changes;
it's from the refactor SymField PR by others.
hence i don't understand how it works, i can't fix it.


clang-format keeps saying syntex err, moving define to the top doesn't help and i don't want to use const var to waste ram.

feel free to submit change-request if you don't like, and i'll use const var instead.

@zxkmm zxkmm marked this pull request as ready for review October 28, 2024 06:37
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
May solve #2336

@gullradriel gullradriel merged commit bea9f44 into portapack-mayhem:next Nov 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants