Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add about_simple updater from github #2328

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Conversation

LupusE
Copy link
Contributor

@LupusE LupusE commented Oct 30, 2024

As mentioned in Discord, I created a file updater/generator for the 'about' page.
The Information are requested via Github API. The names are cleaned to characters only printable by PP.

@eried
Copy link
Member

eried commented Nov 1, 2024

This is awesome! thanks for writing it :)

@gullradriel
Copy link
Member

What's the default sorting for the list ? If it's alphanumeric, it's not fair.
Maybe we should sort the list by number of authored commits ?

@eried
Copy link
Member

eried commented Nov 1, 2024

What's the default sorting for the list ? If it's alphanumeric, it's not fair. Maybe we should sort the list by number of authored commits ?

thats the sorting now, it is github's default

@LupusE
Copy link
Contributor Author

LupusE commented Nov 1, 2024

What's the default sorting for the list ? If it's alphanumeric, it's not fair. Maybe we should sort the list by number of authored commits ?

See https://api.github.com/repos/portapack-mayhem/mayhem-firmware/contributors
The default sorting is already 'most contributions', so I haven't add any logic. This counts only the git repo, not the git wiki. I haven't found a API request for that for now. Work in progress.
One change will be to fill up the names by char count, sorted by "char count 30". This could lead to LupusE with 2 contributions next to eried with 492 contributions....

@eried
Copy link
Member

eried commented Nov 1, 2024

I think that sorting is ok, I just remember when doing it manually I was fitting shorter names on some lines but no need for any "artisan" handling like that. If you find a way for the wiki that would be brilliant! the whole wiki thing feels like an afterthought for github tho, tracking changes is also very cumbersome

@zxkmm
Copy link
Contributor

zxkmm commented Nov 2, 2024

Sorry that we may still need to figure out the deep cause of the lagging issue that randomly appear when touching the menu item list.

HTotoo and I tried many times on it recently, but still in bad luck. and if that can't be resolved, we currently cannot touch the about_simple page.

But as a script that we do not need to force apply, I think it looks good. Maybe add an comment on the file top and printed hint message to mention the issue and I'll approve this.

Also personally I have two one tiny suggestions:

  • I personally like current rank method (by PR count) and also I like alphabet too, maybe that can be an option (arg), but also feel free to keep it as it is now, since I think most people would agree with current one, it's up to you.

This suggestions is just suggestions, not change request, so it's up to you whether to add then or not. And if you made your decision, feel free to tell me and I'll approve this PR.

Copy link
Contributor

@zxkmm zxkmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the filename should be
generate_ui-about-simple.cpp.py
instead of
generate_ui-about-simple.ccp.py
hahaha

@zxkmm zxkmm merged commit da53227 into portapack-mayhem:next Nov 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants