-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add about_simple updater from github #2328
Conversation
This is awesome! thanks for writing it :) |
What's the default sorting for the list ? If it's alphanumeric, it's not fair. |
thats the sorting now, it is github's default |
See https://api.github.com/repos/portapack-mayhem/mayhem-firmware/contributors |
I think that sorting is ok, I just remember when doing it manually I was fitting shorter names on some lines but no need for any "artisan" handling like that. If you find a way for the wiki that would be brilliant! the whole wiki thing feels like an afterthought for github tho, tracking changes is also very cumbersome |
Sorry that we may still need to figure out the deep cause of the lagging issue that randomly appear when touching the menu item list. HTotoo and I tried many times on it recently, but still in bad luck. and if that can't be resolved, we currently cannot touch the about_simple page. But as a script that we do not need to force apply, I think it looks good. Maybe add an comment on the file top and printed hint message to mention the issue and I'll approve this. Also personally I have
This suggestions is just suggestions, not change request, so it's up to you whether to add then or not. And if you made your decision, feel free to tell me and I'll approve this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the filename should be
generate_ui-about-simple.cpp.py
instead of
generate_ui-about-simple.ccp.py
hahaha
…p.py Rename file, fix typo
As mentioned in Discord, I created a file updater/generator for the 'about' page.
The Information are requested via Github API. The names are cleaned to characters only printable by PP.