Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

splash fix and draw bmp fuc logic wrong #2376

Merged
merged 10 commits into from
Nov 20, 2024
Merged

splash fix and draw bmp fuc logic wrong #2376

merged 10 commits into from
Nov 20, 2024

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Nov 20, 2024 •
edited
Loading

  • fix splash draw location
  • fix the draw bmp from sdcard func calculated position 1 line off/wrong
  • rename drawBMP to draw_bmp_from_bmp_hex_arr (to prevent the function name mislead developers)
  • rename drawBMP2 to draw_bmp_from_sdcard_file (to prevent the function name mislead developers)
  • rename BMPView class into SplashScreenView

@gullradriel
Copy link
Member

I didn't saw the rename parts. Do not mind the eventual open/close conversation you saw.
I'm good with your changes

@zxkmm
Copy link
Contributor Author

zxkmm commented Nov 20, 2024

Thx, i haven't rename them yet

gullradriel
gullradriel approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in discord, looks good to me

@zxkmm zxkmm changed the title splash fix splash fix and draw bmp fuc logic wrong Nov 20, 2024
@zxkmm zxkmm marked this pull request as ready for review November 20, 2024 09:32
@zxkmm zxkmm merged commit e88e0b5 into portapack-mayhem:next Nov 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gullradriel gullradriel gullradriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxkmm @gullradriel